Reduce casts for LEAD/LAG #9468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
comphead
commented
Mar 5, 2024
| ----RepartitionExec: partitioning=Hash([i@0], 4), input_partitions=4 | ||
| ------AggregateExec: mode=Partial, gby=[i@0 as i], aggr=[] | ||
| --------MemoryExec: partitions=4, partition_sizes=[1, 2, 1, 1] | ||
| #query TT |
There was a problem hiding this comment.
This test is failing on my local, not sure if its my PR, as there is no window in the plan
comphead
commented
Mar 5, 2024
| @@ -400,7 +400,7 @@ AggregateExec: mode=FinalPartitioned, gby=[i@0 as i], aggr=[] | |||
| --CoalesceBatchesExec: target_batch_size=8192 | |||
| ----RepartitionExec: partitioning=Hash([i@0], 4), input_partitions=4 | |||
| ------AggregateExec: mode=Partial, gby=[i@0 as i], aggr=[] | |||
| --------MemoryExec: partitions=4, partition_sizes=[1, 2, 1, 1] | |||
| --------MemoryExec: partitions=4, partition_sizes=[1, 1, 2, 1] | |||
There was a problem hiding this comment.
I dont see how the PR can affect the partition size distribution as the test plan doesn't have window. More likely the test is odd
mustafasrepo
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Reduce number of unnecessary casts from
i64tousizeand vice versaWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?